wire: Add epoch field to mix key exchange message #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The epoch will be included in the derivation of the session hash, instead of only deriving a session from previous pair requests. This allows new messages in following epochs to not conflict with previous session attempts of the same pair request set. This also provides a decent heuristic to discover and exclude any peers that were unresponsive for a full epoch or more. This is a breaking API change but the wire module has not seen a release since mixing messages were added.
davecgh
approved these changes
May 4, 2024
davecgh
added
the
wire protocol change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The epoch will be included in the derivation of the session hash, instead of only deriving a session from previous pair requests. This allows new messages in following epochs to not conflict with previous session attempts of the same pair request set.
This also provides a decent heuristic to discover and exclude any peers that were unresponsive for a full epoch or more.
This is a breaking API change but the wire module has not seen a release since mixing messages were added.