Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Update required minimum protocol version. #3221

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Feb 19, 2024

Any node that has a protocol version before RemoveRejectVersion is definitely forked off.

Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, this seems to have been the original plan for 1.8.0 as described in #2546.

Then, in the following release:

  • Make the new protocol version introduced in v1.7.0 the minimum required protocol version to participate in the network

Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nack after further inspection.

wallet has a dumb bug that is limiting its maximum pver to InitStateVersion. Bumping dcrd master/1.9.0 to require RemoveRejectVersion would break 1.8.x wallets.

@dajohi dajohi force-pushed the update-remove-old-nodes branch from c293cc8 to 639e491 Compare February 19, 2024 22:37
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

server.go Outdated Show resolved Hide resolved
This updates the required minimum protocol version to the maximum
set by dcrwallet 1.8.0.  Outbound connections will require the
current protocol version.
@dajohi dajohi force-pushed the update-remove-old-nodes branch from 639e491 to fb0fa6a Compare February 19, 2024 23:09
@davecgh davecgh changed the title dcrd: update the required minimum protocol version server: Update required minimum protocol version. Feb 19, 2024
@davecgh davecgh merged commit 20dedca into decred:master Feb 19, 2024
2 checks passed
@davecgh davecgh added this to the 1.9.0 milestone Feb 19, 2024
@davecgh davecgh added the wire protocol change Discussion and pull requests regarding items that require changes to the wire protocol. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wire protocol change Discussion and pull requests regarding items that require changes to the wire protocol.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants