[release-v1.7] main: Use backported addrmgr updates. #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
approved these changes
Apr 7, 2023
The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete.
This bumps the go directive for the addrmgr module to 1.17 which will allow the new module graph pruning and lazy loading capabilities introduced in Go 1.17 to be used once the updated modules are released. This means that, as described by the documentation, the go.mod file for the module now include a separate require block that includes all of the indirect dependencies.
This modifies the addrmgr module to use the new formatting of doc comments in the Go 1.19 release.
This adds a missing break statement to the range over the map of addresses used to select a random entry from the map. Previously the loop would continue needlessly until the entire map was traversed. This is a minor optimization.
This updates the (*KnownAddress).chance method in the following ways: 1. Apply a lower limit to the return value. Using 0.01 as this minimum prevents tiny chance values from causing excessive iterations in (*AddrManager).GetAddress, currently the only caller. 2. Replace an inefficient loop with a single math.Pow. These changes are mitigations to excessive CPU use in the GetAddress method that manifest when the number of attempts for a KnownAddress becomes large. However, this method and much of addrmgr should be rewritten in the future since there are some ad hoc and questionable approaches to candidate address selection.
This updates the 1.7 release to use the latest version of the addrmgr module which includes updates to mitigate excessive CPU usage in testnet scenarios and slightly improve address selection efficiency. In particular, the following updated module version is used: - github.com/decred/dcrd/addrmgr/[email protected]
davecgh
force-pushed
the
rel17_addrmgr_backports
branch
from
138a6ee to
2a3304b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the 1.7 release to use the latest version of the
addrmgrmodule which includes updates to mitigate excessive CPU usage in testnet scenarios and slightly improve address selection efficiency.In particular, the following updated module version is used:
Note that it also cherry picks all of the commits included in updates to the
addrmgr/v2module to ensure they are also included in the release branch even though it is not strictly necessary since thego.modhas been updated to require the newaddrmgr/v2.0.1release and thus will pull in the new code. However, from past experience, not having code backported to modules available in the release branch too leads to headaches for devs building from source in their local workspace with overrides such as those ingo.work.