blockchain: Reject params with mask approval bit. #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_reject_params_with_mask_approval_bit
branch
3 times, most recently
from
fe57759 to
6f8490c
Compare
dajohi
approved these changes
Mar 7, 2023
This adds an additional validation check to the chain initialization process to validate that the mask of the deployments in the given chain params do not use the bit that is reserved for use to signal whether or not the regular transaction tree of the parent block should be considered valid. It also adds a test for the new validation logic.
davecgh
force-pushed
the
blockchain_reject_params_with_mask_approval_bit
branch
from
6f8490c to
fdfc39d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional validation check to the chain initialization process to validate that the mask of the deployments in the given chain params do not use the bit that is reserved for use to signal whether or not the regular transaction tree of the parent block should be considered valid.
It also adds a test for the new validation logic.