netsync: Re-request data sooner after peer disconnect #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Mar 1, 2023
davecgh
reviewed
Mar 8, 2023
There was a problem hiding this comment.
I did some testing on this and noticed it uncovered a bug with the known inventory code. I'll resolve that issue in a separate PR, but this one works properly once that issue is resolved.
EDIT: For reference, the aforementioned issue is resolved by #3074.
Please squash it to a single commit and I'll approve and get it merged.
This change speeds up the relay of blocks and transactions when the peer we have queried for this data disconnects. If any other peers have also announced this data, request the data again immediately from them instead of waiting for a slower peer to announce the data again through an inventory message.
davecgh
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change speeds up the relay of blocks and transactions when the peer we have queried for this data disconnects. If any other peers have also announced this data, request the data again immediately from them instead of waiting for a slower peer to announce the data again through an inventory message.