blockchain: Remove unused db update tracking. #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
approved these changes
Feb 26, 2023
JoeGruffins
approved these changes
Feb 27, 2023
Many years ago, the various threshold states were stored in the database due to performance reasons. However, that logic was removed when the code was updated to support voting since other changes made it quite efficient to simply calculate the states at startup. However, it appears that the dbUpdates field was not removed even though it's not actually used anymore. This removes the field and associated logic accordingly.
davecgh
force-pushed
the
blockchain_remove_unused_db_cache_update_tracking
branch
from
30c3e7f to
961b019
Compare
davecgh
deleted the
blockchain_remove_unused_db_cache_update_tracking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #3060.Many years ago, the various threshold states were stored in the database due to performance reasons. However, that logic was removed when the code was updated to support voting since other changes made it quite efficient to simply calculate the states at startup.
However, it appears that the
dbUpdatesfield was not removed even though it's not actually used anymore. This removes the field and associated logic accordingly.