chaincfg: Rework init time deployment val logic. #3056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the deployment validation logic that runs at initialization time to make it easier to modify and bring it more in line with the more modern coding practices used in the codebase. Similarly, it also reworks the associated deployment validation tests to make them more consistent with modern practices in the code as well as to simplify them and make them more flexible by moving the primary logic for all of the expected results into the test definitions themselves.
The following is a high-level overview of the changes:
math/bits
from thestdlib
for population and trailing zero countsvalidateDeployments
to accept all deployments for all versionsvalidateDeployments
panic
directly in theinit
func