rpcserver: Pass request context to handlers. #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
rpcserver_pass_req_contexts
branch
from
8d86f87 to
9fd612c
Compare
dnldd
approved these changes
Nov 27, 2022
matheusd
approved these changes
Nov 28, 2022
Currently, the handler for the HTTP endpoint passes the server context to the handlers which ensures that they can cancel immediately in the event of server shutdown. Meanwhile, the WebSocket endpoint relies on the server disconnecting the clients when it is shutdown in order to signal cancellation. In both cases, however, the context is not cancelled when a client initiates the disconnect which means handlers do not have the opportunity to cancel early in that case. In order to make it so that the handlers can cancel early in all of the aforementioned scenarios, this modifies the handlers for both the HTTP and WebSocket endpoints to make use of the request context instead of the server context and arranges for each request context to use the server context as their parent context. It also modifies all of the individual websocket-specific handlers to accept the context in the same way the shared handlers for both endpoints do so they are able to make use of early cancellation if desired as well.
davecgh
force-pushed
the
rpcserver_pass_req_contexts
branch
from
9fd612c to
5eda2a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3025.Currently, the handler for the HTTP endpoint passes the server context to the handlers which ensures that they can cancel immediately in the event of server shutdown. Meanwhile, the WebSocket endpoint relies on the server disconnecting the clients when it is shutdown in order to signal cancellation. In both cases, however, the context is not cancelled when a client initiates the disconnect which means handlers do not have the opportunity to cancel early in that case.
In order to make it so that the handlers can cancel early in all of the aforementioned scenarios, this modifies the handlers for both the HTTP and WebSocket endpoints to make use of the request context instead of the server context and arranges for each request context to use the server context as their parent context.
It also modifies all of the individual websocket-specific handlers to accept the context in the same way the shared handlers for both endpoints do so they are able to make use of early cancellation if desired as well.