peer: Use latest pver by default. #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Nov 22, 2022
matheusd
approved these changes
Nov 23, 2022
This updates the max and default protocol version the peer package uses to the latest protocol version (wire.RemoveRejectVersion) and updates the tests to account for the removal of the reject message. It also adds a test that explicitly tests the handler on older protocol versions since the associated message is no longer sent on the latest one.
davecgh
force-pushed
the
peer_use_latest_pver
branch
from
a28fbef to
e9b1b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the max and default protocol version the peer package uses to the latest protocol version (
wire.RemoveRejectVersion) and updates the tests to account for the removal of the reject message.It also adds a test that explicitly tests the handler on older protocol versions since the associated message is no longer sent on the latest one.