blockchain: Change tspend pass log level to debug. #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Dec 31, 2021
blockchain/treasury.go
Outdated
| @@ -1089,7 +1089,7 @@ func (b *BlockChain) checkTSpendHasVotes(prevNode *blockNode, tspend *dcrutil.Tx | |||
| maxRemainingVotes) | |||
| } | |||
|
|
|||
| trsyLog.Infof("TSpend %v passed with: yes %v no %v quorum %v "+ | |||
| trsyLog.Debugf("TSpend %v passed with: yes %v no %v quorum %v "+ | |||
There was a problem hiding this comment.
ACK, but I did like to see this:
2021-12-28 12:30:20.869 [INF] TRSY: TSpend f57f2f35abcfc58cb8d45da6315982610203c1335ee0d68b36240f22c24a557a passed with: yes 6269 no 0 quorum 3456 required 5489
I'll probably start setting the TRSY subsystem to debug.
There was a problem hiding this comment.
Yeah, this should definitely be debug level. It's also the only thing that would be shown at debug, so using debug logging for it would not cause a bunch of extra logging.
davecgh
reviewed
Dec 31, 2021
This changes the tspend passed log level from info to debug since info level doesn't typically log this level of detail.
rstaudt2
force-pushed
the
tspend-passed-log-level
branch
from
52d2fd6 to
d2b5f1e
Compare
davecgh
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
tspendpassed log level frominfotodebugsinceinfolevel doesn't typically log this level of detail.