Support for icon_map

[scinos]

What problem does this PR solve?

Adds support for use custom icons for the weather conditions. This will help the use case where the original icons are too small (or too similar) to be read from a distance, or just be able to use a different icon set for aesthetic reasons.

Proposed solution

Adds a config option icon_map. This YAML dictionary will allow to map each weather condition to an icon to use. If an icon is not present in the map, the default (i.e. the mdi:* icon) will be used.

For example, this config will produce this result:

icon_map:
  "sunny": "mdi:emoticon-cool-outline"

[decompil3d]

Thanks for this contribution. It's looking great so far. I've added a few comments and suggestions. Can you please apply them and let me know when this is ready for another review? Thanks again!

[decompil3d]

Suggested change

	export type Conditions = 'clear-night' | 'cloudy' | 'fog' | 'hail' | 'lightning' | 'lightning-rainy' | 'partlycloudy' | 'pouring' | 'rainy' | 'snowy' | 'snowy-rainy' | 'sunny' | 'windy' | 'windy-variant' | 'exceptional'
	export type IconMap = Partial<Record<Conditions, string>>
	export type Condition = 'clear-night' | 'cloudy' | 'fog' | 'hail' | 'lightning' | 'lightning-rainy' | 'partlycloudy' | 'pouring' | 'rainy' | 'snowy' | 'snowy-rainy' | 'sunny' | 'windy' | 'windy-variant' | 'exceptional';
	type PerConditionConfig<TValue> = Partial<Record<Condition, TValue>>;
	export type IconMap = PerRecordConfig<string>;

[decompil3d]

And then replace the ColorConfig interface below with:

export type ColorConfig extends PerConditionConfig<ColorDefinition>;

[decompil3d]

And edit the type of condition in ConditionSpan and ForecastSegment to Condition instead of string.

[scinos]

I couldn't make it work with export type ColorConfig extends PerConditionConfig<ColorDefinition>;. I tried export interface ColorConfig extends PerConditionConfig<ColorDefinition> {}; but then I got a bunch of type errors every time it iterates over ColorConfig key/value because it thinks value is unknown.

Example:

I guess I can fix it with a bunch of as ColorDefinition, but the forced cast feels wrong to me.

I'm not sure if what I did is equivalent tbh. Let me know what you think.

[decompil3d]

Oh, my bad - I originally had that comment suggesting an interface, but changed to a type and forgot to adjust the syntax. You got it right.

[decompil3d]

Thanks for adjusting. Looks great.