Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to show current weather as the first segment #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gonzalezjj
Copy link
Contributor

This PR adds a config option to add the current weather as the first segment.:

image

image

In its current state, the PR is meant as a request for comments. The following should completed before merging:

  • Tests (I might be able to do that myself)
  • Translations (not sure how to do that, other than by using online translation services)

I'd appreciate some input about this change. Thanks!

@decompil3d
Copy link
Owner

Thanks for the contribution! This looks like a good optional feature. Go ahead and add tests. For localization, the CI will automatically add the other languages when this merges into a branch in the repo itself. Let me know when you're ready for review and I can open a branch and merge yours into it before it goes to main and it should pick up the translations there.

@decompil3d
Copy link
Owner

Apologies for the long delay on this. If you're still keen on adding this feature, would you mind rebasing against the latest main and getting things back up to date? Then I can merge this into a second branch so translations get picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants