CDFE and DBFE writers - Disable safety and document issue #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable container safety restriction on CDFE and DBFE writers.
What is the current behaviour?
Using the JobPart pattern there are cases when a single job instance will have both readers and writers of CDFE or DBFE instances. Unity's safety system flags this as an issue since it thinks they are two separate jobs with concurrent read and write access.
What is the new behaviour?
Unity's safety system is disabled for the CDFE and DBFE writers. This is a temporary work around until #197 can be addressed.
In the meantime you're on your own to ensure you're not reading and writing to component data at the same time.
What issues does this resolve?
What PRs does this depend on?
Does this introduce a breaking change?