Skip to content
This repository has been archived by the owner on Oct 3, 2022. It is now read-only.

redefine type in proto #10

Merged
merged 6 commits into from
Sep 18, 2022
Merged

Conversation

Woojinger
Copy link
Collaborator

@Woojinger Woojinger commented Sep 18, 2022

Description

  • seperate crosschainquery proto
  • add IBCQueryResultPacketData type
  • add proof in IBCQueryResultPacketData and delete proof in query.proto
  • implement cli
  • delete pointer type in proto

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Collaborator

@sujine2 sujine2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good👍

@Woojinger Woojinger changed the title Seperate crosschainquery proto redefine type in proto Sep 18, 2022
Copy link
Collaborator Author

@Woojinger Woojinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing pointer type in proto @sujine2

@Woojinger Woojinger merged commit 78ac81a into ibc-query Sep 18, 2022
@Woojinger Woojinger deleted the feature/seperate-crosschainquery-proto branch September 18, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants