integrate decidim-blogs into main repo #3221
Conversation
ghost
assigned 
|
@decidim/lot-core can anyone help me to understand/solve the failed test please? |
|
@isaacmg410 it's saying this particular key is missing from the locales file, so you should add it |
|
@mrcasals I thought that he was referring to something else. Also, I saw that there was another dot into the index page. |
isaacmg410
changed the title
|
@decidim/lot-core Ready to review and merge |
| @@ -534,6 +534,34 @@ jobs: | |||
| root: coverage | |||
| paths: | |||
| - codeclimate.sortitions.json | |||
| blogs: | |||
There was a problem hiding this comment.
This job is not being used, you need to add it to the workflow at the end of the file. You'll also need to modify the upload-coverage job to increase the number of the -p parameter, and make that job depend on the blogs one.
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ controller or added a new module you need to rename `feature` to `component`. | |||
|
|
|||
| **Added**: | |||
|
|
|||
| - **decidim-blogs**: Decidim Blogs gem has been integrated into the main repository. [\#3221](https://github.com/decidim/decidim/pull/3221) | |||
There was a problem hiding this comment.
There are some weird extra spaces between words here
|
Also, I find it weird that the blogposts have an author. In proposals, meeting and debates, when a resource is created from the admin we show it as "official" and we render the name of the organization instead of the author name, but posts show the name of the user that created it. Is this intended @decidim/product? |
|
@mrcasals I understand that it may seem strange. But is what @decidim/product asked in a face-to-face meeting. The designs are also made with author. On the other hand, what sense does the author have to be "Official"? So therefore, I think the author field would not be necessary. what do you think? Another thing is that a post can not be created from the public part, only the admins via admin site... |
|
@isaacmg410 ok then 🤷♂️ I still can't find any system spec, can you add one them please? |
|
@mrcasals system specs added |
|
@isaacmg410 great, thanks! Some specs are failing though, can you check them please? |
|
@mrcasals It's strange, the specs complain about the design app and decidim-debates ... |
|
So, can be merged? |
|
Right after merging this PR, https://circleci.com/gh/decidim/decidim/88529 😞 |
|
sorry to be so late on the response. Just to be clear, how was the issue of blog entry authorship finally managed? |
|
@xabier it was left as it is, so no changes were applied. |
|
@mrcasals thanks, well done! |
🎩 What? Why?
This PR adds the decidim-blogs into main repo
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)