Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename features to components #2913

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

oriolgual
Copy link
Contributor

@oriolgual oriolgual commented Mar 5, 2018

🎩 What? Why?

Renames all mentions to feature to component.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add a deprecation warning for current_feature

@ghost ghost assigned oriolgual Mar 5, 2018
@ghost ghost added the in-progress label Mar 5, 2018
@deivid-rodriguez
Copy link
Contributor

I'm crying out of emotion 😃. Let's do this!! 🎉

@oriolgual oriolgual force-pushed the feature/rename-features-to-components branch 2 times, most recently from 350b76d to d90927a Compare March 6, 2018 08:14
@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #2913 into master will increase coverage by <.01%.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##           master    #2913      +/-   ##
==========================================
+ Coverage   98.72%   98.72%   +<.01%     
==========================================
  Files        1656     1656              
  Lines       39464    39466       +2     
==========================================
+ Hits        38962    38964       +2     
  Misses        502      502

@oriolgual oriolgual added this to the Release v.0.11.0 milestone Mar 6, 2018
@oriolgual oriolgual force-pushed the feature/rename-features-to-components branch 6 times, most recently from 0cfa56c to cb8070d Compare March 6, 2018 13:20
@oriolgual oriolgual force-pushed the feature/rename-features-to-components branch 3 times, most recently from 88e01e6 to 611c0a8 Compare March 9, 2018 09:21
mrcasals
mrcasals previously approved these changes Mar 9, 2018
@mrcasals
Copy link
Contributor

mrcasals commented Mar 9, 2018

Approved, although I'd add a more detailed note on the CHANGELOG with instructions on what and how to migrate, since this is a big breaking change.

@oriolgual
Copy link
Contributor Author

I'll add it @mrcasals. For regular installations there's nothing to do (except rake decidim:upgrade), if there's something customised it's basically s/feature/component/

@oriolgual oriolgual force-pushed the feature/rename-features-to-components branch from 611c0a8 to 70bf008 Compare March 9, 2018 11:52
mrcasals
mrcasals previously approved these changes Mar 9, 2018
@oriolgual oriolgual force-pushed the feature/rename-features-to-components branch from 70bf008 to b4bd451 Compare March 9, 2018 11:59
@deivid-rodriguez
Copy link
Contributor

No backwards compatibility for external components, right? I remember @josepjaume mentioning keeping register_feature with a deprecation warning. Just asking, I'm fine with hard-dropping it.

@mrcasals
Copy link
Contributor

mrcasals commented Mar 9, 2018

I think we're going for the "move fast, break things" philosophy with this

@deivid-rodriguez
Copy link
Contributor

Sounds good to me! We're at 0.x after all.

Thanks for doing this, it helps.

@oriolgual
Copy link
Contributor Author

@deivid-rodriguez I've kept current_feature with a deprectation warning. If there are a lot of unexpected errors we can add more backwards compatibility fixes.

@oriolgual oriolgual merged commit 5d68eac into master Mar 9, 2018
@ghost ghost removed the in-progress label Mar 9, 2018
@oriolgual oriolgual deleted the feature/rename-features-to-components branch March 9, 2018 13:22
@mrcasals
Copy link
Contributor

mrcasals commented Mar 9, 2018

OMG OMG OMG! 👏 🎈 🎉 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants