Introduce a flag to display the progress

[ferblape]

🎩 What? Why?

This PR introduces a flag to enable/disable progress display in the accountability module. This is useful when there's no progress data uploaded, to avoid all the percentages to be 0% and the progress bar be empty.

📌 Related Issues

• Implements Add a flag to control if the visualization of percentages and progress should be visible #2737

📋 Subtasks

• Add CHANGELOG entry

📷 Screenshots (optional)

New setting:

UI with the setting enabled:

UI with the setting disabled:

[mrcasals]

Thanks for your contribution @ferblape! Code looks good to me, but I left a comment regarding some i18n 😄

[ferblape]

Thanks @mrcasals but maybe you didn't submit the review, because I can't see the comments :D

[mrcasals]

Maybe leave this as "Display progress"?

[ferblape]

👍

[mrcasals]

LOL @ferblape sorry 😞 I left the comment now!

[mrcasals]

@ferblape CI is failing :( ignore the meetings one as it looks like a random failure, but the error in Rubocop is legit (change to_not to not_to)

Please do this and we'll merge it straight away 😄

[codecov]

Codecov Report

Merging #2847 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2847      +/-   ##
==========================================
+ Coverage   98.73%   98.73%   +<.01%     
==========================================
  Files        1636     1636              
  Lines       38719    38730      +11     
==========================================
+ Hits        38230    38241      +11     
  Misses        489      489

[ferblape]

Or even better .to have_no_content, which is faster than .not_to have_content 🚀

[mrcasals]

@ferblape and they behave differently, and the correct usage here is .to have_no_content 😄

[mrcasals]

Argh, conflicts in the CHANGELOG too! 😞

[mrcasals]

@ferblape tests are now failing because the i18n is not normalized (keys must be sorted alphabetically).

you can run i18n-tasks normalize en from the decidim root folder to fix it 😄 (and there are more conflicts on the CHANGELOG 😭 )

[ferblape]

Done!

…

On 28 February 2018 at 10:40, Marc Riera ***@***.***> wrote: @ferblape <https://github.com/ferblape> tests are now failing because the i18n is not normalized (keys must be sorted alphabetically). you can run i18n-tasks normalize en from the decidim root folder to fix it 😄 (and there are more conflicts on the CHANGELOG 😭 ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2847 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABE0OJHEiCR7sV4_tR8zFHP01PNdwiqks5tZR8TgaJpZM4SVBV5> .

-- Fernando Blat twitter.com/ferblape Populate / Projects for civic engagement http://populate.tools

[mrcasals]

Yay, thanks! 🎉

[ferblape]

👯