Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook on feature permission update #2809

Merged
merged 3 commits into from
Feb 26, 2018

Conversation

deivid-rodriguez
Copy link
Contributor

🎩 What? Why?

In order to enforce some restrictions on feature permissions, we'd like to enable a hook to be run on feature permissions update. It works just like the other feature hooks we already have.

📌 Related Issues

None.

📋 Subtasks

  • Add CHANGELOG entry
  • Another subtask

📷 Screenshots (optional)

None.

@ghost ghost added the in-progress label Feb 23, 2018
@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

Merging #2809 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
+ Coverage   98.85%   98.86%   +<.01%     
==========================================
  Files        1582     1583       +1     
  Lines       37432    37467      +35     
==========================================
+ Hits        37005    37040      +35     
  Misses        427      427

@mrcasals
Copy link
Contributor

Nice!

@mrcasals
Copy link
Contributor

Now that I think of it, do we have any docs on the available hooks for features? 🤔 I'll open an issue to track it.

@mrcasals mrcasals merged commit 1aa53ed into master Feb 26, 2018
@mrcasals mrcasals deleted the feature/add_hooks_on_feature_permission_update branch February 26, 2018 08:09
@ghost ghost removed the in-progress label Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants