resource_path and resource_url should be public for events #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
oriolgual
force-pushed
the
fix/method_visibility_for_notifications
branch
from
5dae01e
to
f6d93c6
Compare
mrcasals
previously approved these changes
Feb 6, 2018
oriolgual
force-pushed
the
fix/method_visibility_for_notifications
branch
from
f6d93c6
to
3242033
Compare
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
+ Coverage 98.82% 98.82% +<.01%
==========================================
Files 1435 1435
Lines 33594 33600 +6
==========================================
+ Hits 33200 33206 +6
Misses 394 394 |
mrcasals
previously approved these changes
Feb 6, 2018
oriolgual
force-pushed
the
fix/method_visibility_for_notifications
branch
from
3242033
to
a572610
Compare
oriolgual
force-pushed
the
fix/method_visibility_for_notifications
branch
from
a572610
to
cef7175
Compare
mrcasals
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When listing notifications at the user panel the
resource_pathorresource_urlcould be used by the views, so we need to make sure these methods are public.📌 Related Issues
📋 Subtasks
CHANGELOGentry