Component item created notifications #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
oriolgual
force-pushed
the
feature/component_item_created_notifications
branch
from
eb8fd6a
to
e8abbeb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
==========================================
+ Coverage 98.35% 98.82% +0.47%
==========================================
Files 1443 1445 +2
Lines 33842 33909 +67
==========================================
+ Hits 33285 33511 +226
+ Misses 557 398 -159 |
oriolgual
force-pushed
the
feature/component_item_created_notifications
branch
from
e8abbeb
to
43ddd81
Compare
mrcasals
reviewed
Feb 6, 2018
| def participatory_space_title | ||
| return unless participatory_space | ||
|
|
||
| participatory_space.title[I18n.locale.to_s] |
There was a problem hiding this comment.
I think it'd be nice if we used this here:
It's a little cleverer as it tries some fallbacks, what do you think?
oriolgual
force-pushed
the
feature/component_item_created_notifications
branch
2 times, most recently
from
bd2d296
to
5687296
Compare
mrcasals
reviewed
Feb 6, 2018
| return unless resource | ||
|
|
||
| if resource.respond_to?(:title) | ||
| translated_attribute(resource.title) |
There was a problem hiding this comment.
This method needs the current organization, won't it fail here?
oriolgual
force-pushed
the
feature/component_item_created_notifications
branch
from
5687296
to
73bc78e
Compare
mrcasals
previously approved these changes
Feb 6, 2018
oriolgual
force-pushed
the
feature/component_item_created_notifications
branch
from
a88d3e6
to
b2b5f92
Compare
oriolgual
force-pushed
the
feature/component_item_created_notifications
branch
from
a5403b4
to
6b55ee8
Compare
mrcasals
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Sends a notification to participatory space followers when a meeting or proposal are created.
I've also fixed a typo "an simple event" to "a simple event"
📌 Related Issues
📋 Subtasks
CHANGELOGentry