Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscores at CTA button path #2625

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Conversation

oriolgual
Copy link
Contributor

🎩 What? Why?

It was missing the underscore at the regex.

📌 Related Issues

@ghost ghost assigned oriolgual Feb 1, 2018
@ghost ghost added the in-progress label Feb 1, 2018
mrcasals
mrcasals previously approved these changes Feb 1, 2018
Copy link
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG, please?

@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #2625 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2625      +/-   ##
==========================================
+ Coverage   98.81%   98.81%   +<.01%     
==========================================
  Files        1434     1434              
  Lines       33477    33480       +3     
==========================================
+ Hits        33081    33084       +3     
  Misses        396      396

@oriolgual oriolgual force-pushed the fix/cta_path_with_underscores branch from 4b5725e to 6c5f6fd Compare February 1, 2018 13:42
@mrcasals mrcasals merged commit b1839e3 into master Feb 1, 2018
@mrcasals mrcasals deleted the fix/cta_path_with_underscores branch February 1, 2018 14:17
@ghost ghost removed the in-progress label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants