Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat link projects to results #2467

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Conversation

isaacmg410
Copy link
Contributor

🎩 What? Why?

In order to create a relation between projects and results as we have between proposals and projects. We should be allowed to link one or more projects to a result.

📌 Related Issues

📋 Subtasks

  • Add selector of projects on results admin
  • Add views of projects on results frontend

@isaacmg410 isaacmg410 changed the title [WIP] #2279 feat link projects to results [WIP] feat link projects to results Jan 10, 2018
@codecov
Copy link

codecov bot commented Jan 10, 2018

Codecov Report

Merging #2467 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
+ Coverage   98.68%   98.68%   +<.01%     
==========================================
  Files        1296     1296              
  Lines       30285    30336      +51     
==========================================
+ Hits        29887    29938      +51     
  Misses        398      398

oriolgual
oriolgual previously approved these changes Jan 11, 2018
@isaacmg410 isaacmg410 changed the title [WIP] feat link projects to results feat link projects to results Jan 11, 2018
Copy link
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Can you add a CHANGELOG entry, please?

@mrcasals mrcasals merged commit 71a22a1 into master Jan 12, 2018
@mrcasals mrcasals deleted the 2279_link_projects_to_results branch January 12, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants