Fix default locale problems #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @josepjaume, @oriolgual and @mrcasals to be potential reviewers. |
deivid-rodriguez
approved these changes
Aug 18, 2017
There was a problem hiding this comment.
Yes, nice ❤️! I noticed this while working on #1741, but forgot to fix it...
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
+ Coverage 98.59% 98.61% +0.01%
==========================================
Files 970 970
Lines 22214 22219 +5
==========================================
+ Hits 21902 21911 +9
+ Misses 312 308 -4 |
ghost
removed
the
beagleknight
added a commit
that referenced
this pull request
Aug 21, 2017
* Add default locale to decidim generator * Organization default locale should be included in available locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Our generator wasn't including the
Decidim.default_localeso theOrganizationcreated by default in some organization had the wrong value.We also had a missing validation in the
Organizationmodel.📌 Related Issues
None
📋 Subtasks
None
📷 Screenshots (optional)
N/A
👻 GIF
None