Incorporate tbdex vector results into report #99
Conversation
Co-authored-by: Finn Herzfeld <[email protected]>
phoebe-lew
requested review from
decentralgabe,
mistermoe,
frankhinek and
amika-sq
as code owners
|
@phoebe-lew would it make more sense to init hermit inside of the |
|
@mistermoe hmm could do either, yeah! I tended to open the entire repo in Goland, but not sure what others usually do. @alecthomas will it be fine to have the |
|
Definitely preferable at the root, so that it activates automatically when you cd into it. |
|
I usually open the root. I found thought it was a little confusing to move the go.mod into a subdir but that was what was requested 🤷 |
| Name: "tbdex-js", | ||
| Repo: "TBD54566975/tbdex-js", | ||
| ArtifactName: "junit-results", | ||
| FeatureRegex: regexp.MustCompile(`TbdexTestVectors(\w+)`), |
There was a problem hiding this comment.
so you have been naming your tests:
TbdexTestVectorsClassFeature ?
for example:
TbdexTestVectorsRfqCreate ?
There was a problem hiding this comment.
Ah yep, Think I have a copy paste error for the vector regex though!
| for _, report := range reports { | ||
| for category, tests := range report.Results { | ||
| if _, ok := tests[category]; !ok { | ||
| testmap[category] = map[string]bool{} | ||
| if report.SDK.Type == "web5" { | ||
| testmap[category] = map[string]bool{} |
There was a problem hiding this comment.
nit: could we rename this to web5TestMap?
There was a problem hiding this comment.
you shouldn't need to initialize like this..., but if it breaks pls use make(map[string]bool)
| Tests map[string][]string | ||
| Reports []Report | ||
| Web5Tests map[string][]string | ||
| TbDEXTests map[string][]string | ||
| } | ||
|
|
||
| func WriteHTML(reports []Report, filename string) error { | ||
| slog.Info("writing html report", "reports", len(reports)) | ||
|
|
||
| testmap := make(map[string]map[string]bool) |
There was a problem hiding this comment.
| testmap := make(map[string]map[string]bool) | |
| testMap := make(map[string]map[string]bool) |
for consistency
| @@ -0,0 +1 @@ | |||
| .go-1.21.5.pkg | |||
closes #83