add json schemas for vc and did data models #127
Conversation
decentralgabe
requested review from
mistermoe,
phoebe-lew,
frankhinek and
amika-sq
as code owners
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-2020-12/schema#", | |||
There was a problem hiding this comment.
idk if we conform to this now
https://github.com/TBD54566975/web5-spec/blob/main/test-vectors/did_dht/resolve.json
There was a problem hiding this comment.
yeah DHT is not supporting this since we don't have a dht resolver yet
spec/vc-11.json
Outdated
| }, | ||
| "required": ["id", "type", "statusPurpose", "statusListIndex", "statusListCredential"] | ||
| }, | ||
| "credentialSchema": { |
There was a problem hiding this comment.
is the formatting off here?
There was a problem hiding this comment.
we dont have credentialSchema in js currently, but its not required so a todo for now
There was a problem hiding this comment.
no problem - this should lead the impls
| }, | ||
| "issuer": { | ||
| "oneOf": [ | ||
| { "type": "string" }, |
There was a problem hiding this comment.
this will be our default when creating, but we will accept creds that are
{ id: 123, name: myname} right?
currently if we get a jwt, we use what is in the iss for buildling the vc and adding the issuer
so if we get
iss: abc
vcDataModel.issuer: { id: abc, name: myname}
we will blast it and make vcDataModel.issuer: abc
| "type": "string", | ||
| "format": "date-time" | ||
| }, | ||
| "credentialSubject": { |
There was a problem hiding this comment.
It may have an id, will we accept an external vc without and id?
There was a problem hiding this comment.
the doc here specifies it must be present https://github.com/TBD54566975/web5-spec/blob/main/spec/vc.md#verifiable-credential-data-model
There was a problem hiding this comment.
we could certainly accept creds without em but we shouldn't produce creds without ids
There was a problem hiding this comment.
is this did-document.json?
fix #126