enforcing controller type to be a list of string
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jiyoonie9
commented
Feb 28, 2024
test-vectors/did_jwk/resolve.json
Outdated
| "https://www.w3.org/ns/did/v1", | ||
| "https://w3id.org/security/suites/jws-2020/v1" | ||
| ], | ||
| "@context": "https://www.w3.org/ns/did/v1", |
There was a problem hiding this comment.
forcing @context to be a string, not a list of strings
There was a problem hiding this comment.
could you force this to be a list of strings? I think that will be the most common case for context (if we should choose to use it)
There was a problem hiding this comment.
sure, that sounds good! i'll update the original PR to build DIDDocument with a list of string for @context now.
jiyoonie9
commented
Feb 28, 2024
| @@ -88,7 +88,9 @@ | |||
| }, | |||
| "output": { | |||
| "id": "did:dht:cyuoqaf7itop8ohww4yn5ojg13qaq83r9zihgqntc5i9zwrfdfoo", | |||
| "controller": "did:example:abcd", | |||
| "controller": [ | |||
There was a problem hiding this comment.
forcing controller to be a list of strings
jiyoonie9
changed the title
controller type to be a list of string controller type to be a list of string and @context type to be a string
jiyoonie9
requested review from
decentralgabe,
mistermoe,
phoebe-lew,
frankhinek and
amika-sq
as code owners
decentralgabe
approved these changes
Mar 6, 2024
jiyoonie9
changed the title
controller type to be a list of string and @context type to be a stringcontroller type to be a list of string
mistermoe
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocks decentralized-identity/web5-kt#248