-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Alg 4 #61
Adds Alg 4 #61
Conversation
Signed-off-by: Sam Curren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the info from the FAQs section from the hackmd outlining did:peer:4 that I put together might be good to include here in some form but I don't feel strongly about that.
From @dbluhm Co-authored-by: Daniel Bluhm <[email protected]>
Signed-off-by: Sam Curren <[email protected]>
Very minor editorial notes. Looks great! |
Hi, we will start implementation in aries-vcx of this perhaps through out the next week or beginning of October. It would be great if the PR can stay open for a while, so we can provide feedback from our experience implementing this. |
decentralized-identity/did-peer-4#1 (comment)
|
@FabioPinheiro The two forms, long and short, do not represent two separate identities. The whole idea is that they represent exactly the same set of keys and endpoints. The goal of the short vs long form is to enable more compact kids in DIDComm v2. That being said, it is technically perfectly acceptable to always use the long form of the DID. A DID query was briefly considered; however, there is precedent in the form of did:ion for having a short form and long form style DID. Then, the documents resolved from short and long form are declared to be "aliases" for each other through the use of the Copying note for emphasis:
In my opinion, this is the closest match for our goals and the cleanest way to express the relationship between the short and long form in a way that is supported by the DID Core spec. |
Signed-off-by: Sam Curren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — let’s merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serviceEndpoint
need to be fix to follow the specs
This will change also all the did
s in here short and long form
Agreed with @FabioPinheiro, we should correct these examples to make sure we're promoting correctly constructed didcomm v2 services and not causing any confusion. |
Definitely want the examples right!!! Thanks @FabioPinheiro ! |
service endpoint corrections Co-authored-by: Fabio Pinheiro <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
fix: make sure examples follow didcomm v2 spec
I did not know you could do that. 👍 |
@FabioPinheiro examples corrected. |
I built a tool for quickly parsing/resolving and generating did:peer:4 DIDs: |
Now merging, given the approvals, implementations, and time. |
Adds @dbluhm's Alg 4 into the spec.