Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use multikey #1

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: use multikey #1

merged 1 commit into from
Oct 20, 2023

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Oct 20, 2023

This addresses usage of publicKeyMultibase that was out of spec with what was intended in the DID Core spec. Namely, publicKeyMultibase only expresses the encoding of the value and does not necessarily include the multicodec binary header. Presence or absence of this header should be determined by the verification method type definition. Multikey accomplishes this goal and also cleans up some aspects of the spec and this implementation.

This addresses usage of `publicKeyMultibase` that was out of spec with
what was intended in the DID Core spec. Namely, `publicKeyMultibase`
only expresses the encoding of the value and does not necessarily
include the multicodec binary header. Presence or absence of this header
should be determined by the verification method type definition.
[Multikey](https://www.w3.org/TR/vc-data-integrity/#multikey)
accomplishes this goal and also cleans up some aspects of the spec and
this implementation.

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm dbluhm merged commit 0d67aee into main Oct 20, 2023
4 checks passed
@dbluhm dbluhm deleted the feature/multikey branch October 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant