Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix smart wearbale multiple issues #6080

Merged
merged 4 commits into from
Feb 8, 2024
Merged

fix smart wearbale multiple issues #6080

merged 4 commits into from
Feb 8, 2024

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Feb 2, 2024

What does this PR change?

Closes #5951

...

How to test the changes?

  1. Launch the explorer
  2. ...

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@gonpombo8 gonpombo8 marked this pull request as ready for review February 5, 2024 17:58
@Ludmilafantaniella Ludmilafantaniella self-requested a review February 5, 2024 18:19
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Fail on Browser & Desktop using Mac.
If I equip the Smart Wearable (Hyper Jump shoes) on the Genesis Plaza:

  1. The pop-up sometimes appears and sometimes doesn't.
  2. The Hyper Jump doesn't work.

I go to another location:

  1. The Hyper Jump doesn't work.
  2. I refresh the browser; the pop-up appears every time I equip and unequip and the Hyper Jump shoes work.
  3. I refresh the browser.
  4. The pop-up doesn't appear, the hyper jump doesn't work, and the prompt to press F to activate it also disappears.
  5. Equipping and unequipping don't show the message or perform the expected function.
Screen.Recording.2024-02-05.at.16.43.29.mp4

@Ludmilafantaniella Ludmilafantaniella self-requested a review February 6, 2024 19:41
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This issue was verified on Desktop and Browser using Mac. When equiping the Hyper Jump shoes displays the pop-up and works as expected each time the shoes are equipped and also after refreshing the browser.

Screen.Recording.2024-02-06.at.16.52.34.mp4

@gonpombo8 gonpombo8 merged commit 713cf8c into dev Feb 8, 2024
11 checks passed
@gonpombo8 gonpombo8 deleted the fix/px-issues branch February 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart Wearable Ability not working
3 participants