Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Components [SDK 7] #6052

Merged
merged 23 commits into from
Feb 1, 2024
Merged

Player Components [SDK 7] #6052

merged 23 commits into from
Feb 1, 2024

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Jan 10, 2024

decentraland/js-sdk-toolchain#866

What does this PR change?

...

How to test the changes?

  1. Launch the explorer
  2. ...

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@gonpombo8 gonpombo8 force-pushed the feat/avatar-positions branch from 34e5bf7 to e06a577 Compare January 16, 2024 20:07
@gonpombo8 gonpombo8 marked this pull request as ready for review January 31, 2024 06:10
@gonpombo8 gonpombo8 requested a review from a team as a code owner January 31, 2024 06:10
@github-actions github-actions bot requested review from LucasLioyQA and popuz January 31, 2024 06:10
@gonpombo8 gonpombo8 changed the title wip add PlayerInfo & Transform for each avatar on sdk7 scenes Player Components [SDK 7] Jan 31, 2024
@Ludmilafantaniella Ludmilafantaniella self-requested a review January 31, 2024 17:06
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed and approved by QA. Tested on browser and Desktop using Mac. No performance issues were experienced, also the console displays correctly the players that are currently on the scene.

image (1)

@gonpombo8 gonpombo8 merged commit 5a1dbe7 into dev Feb 1, 2024
11 checks passed
@gonpombo8 gonpombo8 deleted the feat/avatar-positions branch February 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants