feat: sdk7 renderer restricted actions #5033
Conversation
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
| private static int GetCurrentFrameCount() | ||
| { | ||
| return Time.frameCount; | ||
| } |
There was a problem hiding this comment.
this is a temporal solution, I will change renderer's frame count for scene's tick later on another PR so we avoid having issues with renderer update vs scene update
There was a problem hiding this comment.
Can you add a comment with this on the code?
| catch (Exception _) | ||
| { // ignored | ||
| } |
There was a problem hiding this comment.
I find this dangerous. I think we should catch cancellation exceptions to ignore them but log the rest.
| string urn = 1; | ||
| } | ||
|
|
||
| message SuccessResponse { |
There was a problem hiding this comment.
Are we not saying the same thing twice? Maybe renaming to Response would be better because it can be a non-successful response. Right?
| private static int GetCurrentFrameCount() | ||
| { | ||
| return Time.frameCount; | ||
| } |
There was a problem hiding this comment.
Can you add a comment with this on the code?
What does this PR change?
*add
openExternalUrl*add
openNftDialogfixes decentraland/sdk#665
How to test the changes?
openExternalUrlplayground test linkopenNftDialogplayground test linkOur Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖 Generated by Copilot at 1c37bd5
This pull request adds a new service called the restricted actions service, which allows the renderer to request the user's permission to open external URLs or NFT dialogs. The pull request implements the service using the RPC framework and the protocol buffer syntax. The pull request also modifies the external URL prompt HUD to use the service, and registers the service in the renderer port and the RPC server. The pull request affects several files in the
browser-interfaceandunity-rendererpackages.