fix: sdk7 primitives radius defaults #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
AjimenezDCL
suggested changes
Apr 21, 2023
| @@ -29,7 +29,7 @@ public static Mesh CreateMesh(AssetPromise_PrimitiveMesh_Model meshModelModel) | |||
| } | |||
| else | |||
| { | |||
| mesh = PrimitiveMeshBuilder.BuildSphere(1f); | |||
There was a problem hiding this comment.
Maybe we can take the opportunity to extract a constant, so next time we only have to change it in one place.
There was a problem hiding this comment.
You made me realize that I should have removed that line 😅
Actually default value it's already defaulted in the sphere property constructor here:
…into fix/sdk7-primitives-defaults
pravusjif
approved these changes
Apr 22, 2023
AjimenezDCL
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
changed default radius values for cylinder and sphere
fixes decentraland/sdk#558
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖 Generated by Copilot at 1e96f9f
Reduced the default radius of sphere and cylinder mesh colliders and renderers to improve the consistency and accuracy of the physics simulation and the visual representation of primitive meshes. Adjusted the default sizes of sphere and cylinder mesh builders to match the corresponding mesh models.