fix: sdk7 crdt consensus rules #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
…aland/unity-renderer into fix/crdt-consensus-rules
AjimenezDCL
approved these changes
Apr 21, 2023
pravusjif
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
*change crdt consensus rules to match js-sdk
*renamed
CRDTMessageforCrdtMessage*changed
CrdtMessagetype toreadonly structfixes decentraland/sdk#648
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖 Generated by Copilot at 18459b2
This pull request refactors the CRDT protocol and its related classes to improve performance, readability, and consistency. It renames the
CRDTMessageclass toCrdtMessageand changes it from a class to a struct, and updates the references and serialization logic accordingly. It also fixes some minor issues and improves the error handling and encapsulation of the CRDT service and executor classes. It modifies theAssemblyInfo.csfile to allow internal access to some test assemblies, and updates the expected final CRDT state in thearraybuffer.testfile.