-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: textures memory leak #4455
Conversation
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: More
|
…into fix/texture-leak
…into fix/texture-leak
…into fix/texture-leak
…into fix/texture-leak
…into fix/texture-leak
…into fix/texture-leak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Textures load correctly. No issues detected.
Textures set to Materials were never disposed until the scene was unloaded.
fixed by setting material reference to texture regardless of the texture download state.
fixed by disposing textures when reference count equals 0
note: texture are not removed from component manager after disposed, given the texture nature of disposable component means that the texture component should exist even if there are no reference to it.
fixes decentraland/sdk#607
how to test:
https://play.decentraland.org/?explorer-branch=fix/texture-leak
go around the world, textures and videos should be loading correctly