feat: remove vendors #680
Merged
feat: remove vendors #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosantangelo
force-pushed
the
feat/remove-vendors
branch
from
79b21bf to
b2583f4
Compare
nicosantangelo
force-pushed
the
feat/remove-vendors
branch
from
b2583f4 to
3c8d297
Compare
nicosantangelo
force-pushed
the
feat/remove-vendors
branch
from
3c8d297 to
8d8a99d
Compare
|
Rebasing |
LautaroPetaccio
requested changes
Jun 30, 2022
| @@ -63,6 +66,9 @@ describe('when placing a bid', () => { | |||
| expect(callParameters[1]).toBe( | |||
| 'placeBid(address,uint256,uint256,uint256)' | |||
| ) | |||
| expect(callParameters[1]).toBe( | |||
There was a problem hiding this comment.
Is there a reason to repeat the expect here?
LautaroPetaccio
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #676