feat: Add magic auto authorization feature #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cyaiox
reviewed
Feb 10, 2025
| @@ -56,7 +57,7 @@ const ConfirmRentModal = ({ | |||
| if (isUserTheOperatorAddress) { | |||
| setOperatorAddress('') | |||
| } else { | |||
| setOperatorAddress(wallet!.address) | |||
| setOperatorAddress(wallet?.address) | |||
There was a problem hiding this comment.
should we show an error message when the wallet is undefined?
There was a problem hiding this comment.
The user shouldn't ever reach this modal if the wallet is not defined. I've changed the ! to ? because we shouldn't use the ! anymore.
cyaiox
reviewed
Feb 11, 2025
| } | ||
|
|
||
| const [isLoadingAuthorizations, isAuthorized] = useAuthorization(authorization, onFetchAuthorizations) | ||
| const authorizedContract = !!offchainOrdersContract && isOffchainPublicNFTOrdersEnabled ? offchainOrdersContract : marketplaceContract |
There was a problem hiding this comment.
Suggested change
| const authorizedContract = !!offchainOrdersContract && isOffchainPublicNFTOrdersEnabled ? offchainOrdersContract : marketplaceContract | |
| const authorizedContract = offchainOrdersContract || marketplaceContract |
There was a problem hiding this comment.
Great catch! Changed it
cyaiox
reviewed
Feb 11, 2025
| const contract = getContract({ | ||
| address: authorization.authorizedAddress | ||
| }) | ||
| const handleCreateOrder = () => onCreateOrder(nft, parseMANANumber(price), new Date(`${expiresAt} 00:00:00`).getTime(), fingerprint) |
There was a problem hiding this comment.
Suggested change
| const handleCreateOrder = () => onCreateOrder(nft, parseMANANumber(price), new Date(`${expiresAt} 00:00:00`).getTime(), fingerprint) | |
| const handleCreateOrder = useCallback(() => onCreateOrder(nft, parseMANANumber(price), new Date(`${expiresAt} 00:00:00`).getTime(), fingerprint), [expiresAt, fingerprint, nft, price, onCreateOrder]) |
There was a problem hiding this comment.
Changed it!
cyaiox
approved these changes
Feb 11, 2025
LautaroPetaccio
deleted the
feat/add-magic-auto-authorization-signatures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Magic Auto Authorization feature. This implies that Magic users will not be prompted to authorize contracts on most of the operations on the Marketplace. There's a
SellModalthat still has authorizations, but other operations should not show the authorization modal.The new changes imply that we must propagate the error of the authorizations to the components. This is done in several components, most of them which use the
ConfirmInputValueModalwhich now handles errors.