Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename swanky to rare #184

Merged
merged 1 commit into from
May 26, 2020
Merged

feat: rename swanky to rare #184

merged 1 commit into from
May 26, 2020

Conversation

nicosantangelo
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/decentraland/marketplace/myfd0sc3s
✅ Preview: https://marketplace-git-feat-remove-swanky.decentraland1.now.sh

Copy link
Contributor

@nachomazzara nachomazzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neats

@@ -135,7 +135,7 @@
"mythic": "神话",
"legendary": "传奇",
"epic": "史诗",
"swanky": "时髦",
"rare": "时髦",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is made by someone of the community or should we need to use google translator?

For rare is = 罕见 which is pretty similar (if not the same) as uncommon. The other suggestion is 稀有

@@ -144,7 +144,7 @@
"mythic": "Para algunos pocos: máximo 10",
"legendary": "Ediciión limitada: máximo 100",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but typo here.

@cazala cazala merged commit 81bdcf2 into master May 26, 2020
@cazala cazala deleted the feat/remove-swanky branch May 26, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants