-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename swanky to rare #184
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/decentraland/marketplace/myfd0sc3s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neats
@@ -135,7 +135,7 @@ | |||
"mythic": "神话", | |||
"legendary": "传奇", | |||
"epic": "史诗", | |||
"swanky": "时髦", | |||
"rare": "时髦", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is made by someone of the community or should we need to use google translator?
For rare
is = 罕见 which is pretty similar (if not the same) as uncommon
. The other suggestion is 稀有
@@ -144,7 +144,7 @@ | |||
"mythic": "Para algunos pocos: máximo 10", | |||
"legendary": "Ediciión limitada: máximo 100", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but typo here.
703c143
to
abdbd88
Compare
No description provided.