Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cors support #891

Merged
merged 1 commit into from
Mar 29, 2019
Merged

feat: add cors support #891

merged 1 commit into from
Mar 29, 2019

Conversation

nicosantangelo
Copy link
Contributor

@nicosantangelo nicosantangelo commented Mar 29, 2019 •
edited
Loading 

CORS_ORIGIN=
CORS_METHOD=

Closes #879

nachomazzara
nachomazzara reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@nachomazzara nachomazzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok but, how can I test it?

Could this affect third party apps which uses our API?

nachomazzara
nachomazzara approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@nachomazzara nachomazzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@nachomazzara nachomazzara merged commit bd4f616 into master Mar 29, 2019
@nachomazzara nachomazzara deleted the feat/configure-cors branch March 29, 2019 14:30
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachomazzara nachomazzara nachomazzara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicosantangelo @nachomazzara