Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: handle bid with fingerprint changed #861

Merged
merged 5 commits into from
Mar 11, 2019
Merged

Feat: handle bid with fingerprint changed #861

merged 5 commits into from
Mar 11, 2019

Conversation

nachomazzara
Copy link
Contributor

@nachomazzara nachomazzara commented Feb 25, 2019 •
edited
Loading

Close #859

@nachomazzara nachomazzara force-pushed the feat/handle-bid-with-fingerprint-changed branch from a88f064 to b9341f9 Compare February 25, 2019 16:55
eordano
eordano approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@eordano eordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but content looks good

@nachomazzara nachomazzara force-pushed the feat/handle-bid-with-fingerprint-changed branch from a71288c to 73e9d9d Compare February 28, 2019 18:58
nicosantangelo
nicosantangelo reviewed Mar 7, 2019
View reviewed changes
Copy link
Contributor

@nicosantangelo nicosantangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

shared/bid.js Outdated Show resolved Hide resolved
webapp/src/components/Bid/Bid.js Outdated Show resolved Hide resolved
webapp/src/components/ParcelDetailPage/ParcelDetailPage.js Outdated
{bids
.filter(
bid =>
(isOwner && isOpen(bid)) || (!isOwner && isActive(bid))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is there a name for this?, I mean for the entire condition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try

@nachomazzara nachomazzara force-pushed the feat/handle-bid-with-fingerprint-changed branch from 5c3d67d to 6e9b91b Compare March 7, 2019 21:19
@nicosantangelo nicosantangelo merged commit badb7e9 into master Mar 11, 2019
@nicosantangelo nicosantangelo deleted the feat/handle-bid-with-fingerprint-changed branch March 11, 2019 12:07
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosantangelo nicosantangelo nicosantangelo left review comments

@eordano eordano eordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nachomazzara @eordano @nicosantangelo