Feat: expire expired bids #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared/listing.js
Outdated
| @@ -26,7 +27,7 @@ export const LISTING_SORT_BY = Object.freeze({ | |||
|
|
|||
| export const DEFAULT_DAY_INTERVAL = 31 | |||
| export const MINIMUM_DAY_INTERVAL = 1 | |||
| export const MAXIMUM_BID_DAY_INTERVAL = 6 * 31 // six month | |||
| export const MAXIMUM_BID_DAY_INTERVAL = 182 // six month | |||
There was a problem hiding this comment.
Suggested change
| export const MAXIMUM_BID_DAY_INTERVAL = 182 // six month | |
| export const MAXIMUM_BID_DAY_INTERVAL = 182 // six months |
😛
nachomazzara
commented
Feb 22, 2019
nachomazzara
force-pushed
the
feat/expire-expired-bids
branch
from
baf240e
to
eb00b17
Compare
nicosantangelo
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.