feat: add distict_id to estates and filter bids for distrincts #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Asset/Estate/Estate.model.js
Outdated
| @@ -63,4 +64,15 @@ export class Estate extends Model { | |||
| WHERE ${BlockchainEventQueries.byArgs('_estateId', estateId)} | |||
| OR (${BlockchainEventQueries.byArgs('_tokenId', estateId)} AND address = ${address})`) | |||
| } | |||
|
|
|||
| static async updateEstateDistrictIds() { | |||
There was a problem hiding this comment.
Maybe just updateDistrictIds (we're already in Estate.model) or refreshDistrictIds because update it's already a verb used in SQL
webapp/src/modules/bid/selectors.js
Outdated
| @@ -46,6 +46,10 @@ export const getBidByAssetIdFactory = (assetId, assetType) => | |||
| ) | |||
|
|
|||
| export const getWalletBidsByAsset = (state, asset, assetType) => { | |||
| if (!asset) { | |||
| return [] | |||
| } | |||
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
Because we are using the selector when you create an Estate and the asset is undefined. I should add a comment. What do you think?
nicosantangelo
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distrinct_idtoEstatecolumndistrict_idsonce monitor finishedowner offrom Estate details if it is a districtNote:
npm run migrate up