fix: pending tx estates #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosantangelo
suggested changes
Sep 6, 2018
|
|
||
| .EstateModal .modal-buttons .ui.button + .ui.button { | ||
| margin-left: 0; | ||
| } |
There was a problem hiding this comment.
this changes are not necessary, the shifted buttons are a result of EstateModal lacking a modal-children class on line 85.
Try it on master
webapp/src/components/EstateDetailPage/EditEstateMetadata/EstateModal/EstateModal.js
Show resolved
Hide resolved
| estate, | ||
| estate: { | ||
| id: estate.id, | ||
| data: { name: estate.data.name, parcels: estate.data.parcels } |
There was a problem hiding this comment.
Maybe we could have a utils fn to map the parcels leaving only the necessary props (x,y) ?
There was a problem hiding this comment.
Parcels have an object { x, y } here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #407
Showing Estate pending transactions as:
Also, fix the styles of using
Containerinstead ofdivonformspagesDouble background color
Not full width on mobile when showing pending tx
Rename some
token_idtoidI kept critics renames to be approached in other PR (when we decide to remove
token_idfrom the db)