Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new parcel card #200

Merged
merged 20 commits into from
Apr 30, 2018
Merged

feat: new parcel card #200

merged 20 commits into from
Apr 30, 2018

Conversation

nicosantangelo
Copy link
Contributor

@nicosantangelo nicosantangelo commented Apr 25, 2018 •
edited
Loading

Does a lot more than just redisigning the parcel card:

  • Updates the entire API to be a bit more consistent and return parcels with publications when possible
  • Updates the entire redux saga/store/selectors to use parcels with publications
  • Extracts into it's own component

Steps:

  • npm run migrate up
  • npm run tag
  • psql $CONNECTION_STRING -f scripts/addLastTransferedAt.sql

@nicosantangelo nicosantangelo force-pushed the feat/new-parcel-card branch 3 times, most recently from 1c8be34 to 78776bc Compare April 25, 2018 11:17
@nicosantangelo
Copy link
Contributor Author

nicosantangelo commented Apr 25, 2018 •
edited
Loading

build will continue to fail until decentraland/decentraland-eth#6 is fixed

@nicosantangelo nicosantangelo force-pushed the feat/new-parcel-card branch 5 times, most recently from bad8b4c to 2174c4b Compare April 30, 2018 17:14
@nicosantangelo
feat: update the API to accomodate for new features
a85a70d
@nicosantangelo
feat: add ParcelCard component mocking existing
9b6ee64
@nicosantangelo
feat: update saga api calls. new API requirements
34681d7
@nicosantangelo
feat: finish implementing ParcelCard. move to parcels with publicatio…
0a732a4 
…ns everywhere
@nicosantangelo
chore: remove test code, fix lint and tests
b3cefff
@nicosantangelo
fix: always send default values on filter api call
b9eb8e8
@nicosantangelo
fix: homepage parcel cards style
fd2224a
@nicosantangelo
feat: add last_transfered_at time to parcels
bb3d842
@nicosantangelo
fix: fix last sold at time
f5f126f
@nicosantangelo
fix: don't show highlights title if tags is empty
bd643f3
@nicosantangelo
fix: update specs
e5edabb
@nicosantangelo
fix: show tags in same order. don't clip tooltips
1bdc1e9
@nicosantangelo
fix: filter expired publications
7aebfab
@nicosantangelo
fix: return only open publications on inRange
13eb43c
@nicosantangelo
fix: unique key
eb5f0d0
@nicosantangelo
fix: only show open publication prices
ae8bc04
@nicosantangelo
fix: don't send empty status
4d1db41
@nicosantangelo
fix: correctly fetch asset_ids
2e7d75b
@nicosantangelo
feat: bump decentraland eth
fda2c24
cazala
cazala requested changes Apr 30, 2018
View reviewed changes
webapp/src/components/ParcelCard/ParcelCard.js Outdated
</React.Fragment>
) : (
<Card.Meta>
Acquired at&nbsp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing translation

@cazala cazala merged commit cc22f5e into master Apr 30, 2018
@cazala cazala deleted the feat/new-parcel-card branch April 30, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cazala cazala cazala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicosantangelo @cazala