fix: sign windows exe #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
commented
Sep 25, 2024
| # Due to this issue https://github.com/electron-userland/electron-builder/issues/6411 the build with npx when rebuilding native dependencies hangs forever | ||
| # see https://github.com/cawa-93/vite-electron-builder/pull/953 | ||
| command: ./node_modules/.bin/electron-builder --config electron-builder.yml -c.extraMetadata.version=${{ github.event.inputs.version }} -c.mac.notarize.teamId=${{ env.APPLE_TEAM_ID }} --publish always | ||
| command: npx electron-builder --config electron-builder.cjs -c.extraMetadata.version=${{ github.event.inputs.version }} -c.mac.notarize.teamId=${{ env.APPLE_TEAM_ID }} --publish always |
There was a problem hiding this comment.
The issue that electron-builder had with npx has been fixed in npm v10.1.0
Reference: electron-userland/electron-builder#6411 (comment)
cyaiox
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue we currently have where the Windows
.exefile is being signed after the artifacts are published, so they are not being part of the GitHub release and auto-updater.The issue with
electron-builderis that it cannot generate the artifacts and publish them later, the process cannot be 'paused' in the middle, so we can't run the eSigner GitHub Action to sign it in between.The
electron-builderconfiguration provides an escape hatch to sign the executables in a custom way before publishing them, so what I did is the following:electron-builder.ymlinto anelectron-builder.cjsfile so we can define the customwin.signfunction.SSLcom/esigner-codesignrepo in an earlier step into the root.win.signfunction I execute a sync child process that runs the GitHub Action's script using node..exeafterwards.The eSigner GitHub Action is not intended to be used programatically, so I had to do some ugly wiring for it to pick up the configuration (pass some values into the
process.env) but it works, and it takes care of downloading Java, the CodeSignTool, and perform the signing just fine.I followed this approach from the comment on this issue: electron-userland/electron-builder#6158 (comment)