-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto install & import asset-packs for editor scenes #909
Conversation
c2ccd00
to
3cc3e59
Compare
Deploying with Cloudflare Pages
|
Test this pull request
|
packages/@dcl/inspector/package.json
Outdated
@@ -2,7 +2,7 @@ | |||
"name": "@dcl/inspector", | |||
"version": "0.1.0", | |||
"dependencies": { | |||
"@dcl/asset-packs": "^1.12.2", | |||
"@dcl/asset-packs": "^1.12.3-20240301140405.commit-8aef784", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: make a asset-packs release and use that stable versioin
import { initAssetPacks } from '@dcl/asset-packs/dist/scene-entrypoint' | ||
initAssetPacks(engine) | ||
|
||
// TODO: do we need to do this on runtime ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to another issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 67.13% 67.05% -0.09%
==========================================
Files 529 529
Lines 16676 16710 +34
Branches 2132 2145 +13
==========================================
+ Hits 11196 11205 +9
- Misses 5143 5167 +24
- Partials 337 338 +1 ☔ View full report in Codecov by Sentry. |
With this PR is not mandatory to import and install the @dcl/asset-pack lib for the editor scenes.
The sdk-commands does all this at build-time in the background using the asset-pack version that the inspector used to build the scene.
So this way we don't have mismatched of @dcl/asset-packs version. (The inspector already has the asset-packs lib, and the scene could have another version that could lead into mysterious bugs )
Before (game.ts scene):
Now