Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep sdk comments so we can tag functions as deprecated #902

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

gonpombo8
Copy link
Contributor

No description provided.

@gonpombo8 gonpombo8 force-pushed the feat/keep-sdk-comments branch from adaa155 to c5534ff Compare February 21, 2024 11:26
Copy link

cloudflare-workers-and-pages bot commented Feb 21, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 066ded5
Status: ✅  Deploy successful!
Preview URL: https://99282860.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-keep-sdk-comments.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/keep-sdk-comments/dcl-sdk-7.4.5-8054437032.commit-d372f2f.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/keep-sdk-comments/dcl-sdk-commands-7.4.5-8054437032.commit-d372f2f.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/keep-sdk-comments/@dcl/inspector/dcl-inspector-7.4.5-8054437032.commit-d372f2f.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/keep-sdk-comments-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/keep-sdk-comments

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (35a11db) to head (066ded5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files         524      524           
  Lines       16531    16531           
  Branches     2109     2109           
=======================================
  Hits        11041    11041           
  Misses       5155     5155           
  Partials      335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonpombo8 gonpombo8 force-pushed the feat/keep-sdk-comments branch from e92f49b to 066ded5 Compare February 26, 2024 19:23
@gonpombo8 gonpombo8 merged commit f06a0a7 into main Feb 26, 2024
10 checks passed
@gonpombo8 gonpombo8 deleted the feat/keep-sdk-comments branch February 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant