-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some editor fixes #900
Some editor fixes #900
Conversation
Deploying with Cloudflare Pages
|
Test this pull request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 67.05% 67.03% -0.02%
==========================================
Files 529 531 +2
Lines 16710 16720 +10
Branches 2145 2147 +2
==========================================
+ Hits 11205 11209 +4
- Misses 5167 5171 +4
- Partials 338 340 +2 ☔ View full report in Codecov by Sentry. |
0cdba2b
to
a8d6d17
Compare
@@ -17,7 +17,8 @@ export const putVideoPlayerComponent: ComponentOperation = (entity, component) = | |||
if (entity.gltfAssetContainer) { | |||
// need to re-scale the model to get in sync with scale in preview... | |||
entity.gltfAssetContainer.meshes[0].scaling = new BABYLON.Vector3( | |||
0.2 * scaleMult, | |||
// why negative X coordinate? => https://forum.babylonjs.com/t/left-and-right-handed-shenanagins/17049/4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes: