Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some editor fixes #900

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Some editor fixes #900

merged 8 commits into from
Mar 5, 2024

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Feb 20, 2024

Fixes:

  • Image orientation using does not match. Preview vs Builder
  • Outline shader is too big when editing if you want to place objects on small areas
  • Text in the editor is displayed in a different size from in the engine
  • Current renaming features only has effect if you hit Enter. Added a confirmation modal on blur event
  • Rapid typing often results in missing letters or erratic cursor movements
  • Fix wrong label in tween actions
  • Add proper error messages for GltfValidator
  • Manually changing Gltf src not working
Screenshot 2024-02-20 at 12 28 07

Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3831481
Status: ✅  Deploy successful!
Preview URL: https://83eb5741.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-editor.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/editor/dcl-sdk-7.4.8-8143614732.commit-b2ae932.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/editor/dcl-sdk-commands-7.4.8-8143614732.commit-b2ae932.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/editor/@dcl/inspector/dcl-inspector-7.4.8-8143614732.commit-b2ae932.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/editor-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/editor

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.03%. Comparing base (5809b1b) to head (3831481).

Files Patch % Lines
...s/@dcl/inspector/src/components/Tree/Edit/types.ts 0.00% 4 Missing and 1 partial ⚠️
...bylon/decentraland/sdkComponents/gltf-container.ts 0.00% 3 Missing ⚠️
...s/@dcl/inspector/src/components/Tree/Edit/index.ts 0.00% 1 Missing and 1 partial ⚠️
...babylon/decentraland/sdkComponents/video-player.ts 0.00% 2 Missing ⚠️
...babylon/decentraland/editorComponents/selection.ts 0.00% 1 Missing ⚠️
...b/babylon/decentraland/sdkComponents/text-shape.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   67.05%   67.03%   -0.02%     
==========================================
  Files         529      531       +2     
  Lines       16710    16720      +10     
  Branches     2145     2147       +2     
==========================================
+ Hits        11205    11209       +4     
- Misses       5167     5171       +4     
- Partials      338      340       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza marked this pull request as ready for review March 1, 2024 14:51
@nicoecheza nicoecheza enabled auto-merge (squash) March 5, 2024 12:18
@@ -17,7 +17,8 @@ export const putVideoPlayerComponent: ComponentOperation = (entity, component) =
if (entity.gltfAssetContainer) {
// need to re-scale the model to get in sync with scale in preview...
entity.gltfAssetContainer.meshes[0].scaling = new BABYLON.Vector3(
0.2 * scaleMult,
// why negative X coordinate? => https://forum.babylonjs.com/t/left-and-right-handed-shenanagins/17049/4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicoecheza nicoecheza merged commit 6ea97ea into main Mar 5, 2024
9 of 10 checks passed
@nicoecheza nicoecheza deleted the fix/editor branch March 5, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants