Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sourcemaps path for production builds #898

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

gonpombo8
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3087221
Status: ✅  Deploy successful!
Preview URL: https://8a3a3817.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-path-sourcemaps.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/path-sourcemaps/dcl-sdk-7.4.3-7978361035.commit-77c3652.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/path-sourcemaps/dcl-sdk-commands-7.4.3-7978361035.commit-77c3652.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/path-sourcemaps/@dcl/inspector/dcl-inspector-7.4.3-7978361035.commit-77c3652.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/path-sourcemaps-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/path-sourcemaps

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a250a0d) 66.67% compared to head (3087221) 66.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files         524      524           
  Lines       16504    16505    +1     
  Branches     2103     2104    +1     
=======================================
+ Hits        11004    11005    +1     
  Misses       5165     5165           
  Partials      335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonpombo8 gonpombo8 merged commit 3736ac0 into main Feb 20, 2024
10 checks passed
@gonpombo8 gonpombo8 deleted the fix/path-sourcemaps branch February 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant