Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaleFontSize helper #891

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Add scaleFontSize helper #891

merged 4 commits into from
Feb 19, 2024

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Feb 9, 2024

Copy of CSS calc function but just for vw/vh units

@nicoecheza nicoecheza force-pushed the add/scaling-font-helper branch from 5375902 to 5cf8c41 Compare February 9, 2024 16:19
Copy link

cloudflare-workers-and-pages bot commented Feb 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e88221c
Status: ✅  Deploy successful!
Preview URL: https://662f2095.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-scaling-font-helper.js-sdk-toolchain.pages.dev

View logs

@nicoecheza nicoecheza force-pushed the add/scaling-font-helper branch 4 times, most recently from e35aa32 to 4d6f08d Compare February 9, 2024 17:00
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scaling-font-helper/dcl-sdk-7.4.3-7959953257.commit-8f67692.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scaling-font-helper/dcl-sdk-commands-7.4.3-7959953257.commit-8f67692.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scaling-font-helper/@dcl/inspector/dcl-inspector-7.4.3-7959953257.commit-8f67692.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/scaling-font-helper-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/scaling-font-helper

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e16c799) 67.01% compared to head (e88221c) 67.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   67.01%   67.09%   +0.08%     
==========================================
  Files         523      523              
  Lines       16236    16276      +40     
  Branches     2059     2075      +16     
==========================================
+ Hits        10880    10920      +40     
  Misses       5023     5023              
  Partials      333      333              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza force-pushed the add/scaling-font-helper branch 8 times, most recently from e3c3a2d to 76ad89a Compare February 9, 2024 20:40
@nicoecheza nicoecheza enabled auto-merge (squash) February 9, 2024 20:54
Copy link
Contributor

@gonpombo8 gonpombo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll greate if we can use this values directly on all the properties that accept % and numbers like width, height, fontSize,etc.

<UiEntity uiTransform={{ width: '100vw', fontSize: '1vw' }} />

packages/@dcl/react-ecs/src/components/Label/types.ts Outdated Show resolved Hide resolved
@nicoecheza nicoecheza force-pushed the add/scaling-font-helper branch 6 times, most recently from bb94d54 to 205c768 Compare February 14, 2024 13:48
@nicoecheza nicoecheza force-pushed the add/scaling-font-helper branch 3 times, most recently from 1df2a5e to 27cfd5b Compare February 16, 2024 17:03
@nicoecheza nicoecheza force-pushed the add/scaling-font-helper branch from 27cfd5b to e88221c Compare February 19, 2024 13:01
@nicoecheza nicoecheza merged commit 4aa0343 into main Feb 19, 2024
10 checks passed
@nicoecheza nicoecheza deleted the add/scaling-font-helper branch February 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants