Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap rotation #889

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: wrap rotation #889

merged 2 commits into from
Feb 6, 2024

Conversation

cazala
Copy link
Contributor

@cazala cazala commented Feb 5, 2024

Avoid using negative values for rotation, wrap them around 360

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/wrap-rotation/dcl-sdk-7.4.1-7803521176.commit-31972ea.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/wrap-rotation/dcl-sdk-commands-7.4.1-7803521176.commit-31972ea.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/wrap-rotation/@dcl/inspector/dcl-inspector-7.4.1-7803521176.commit-31972ea.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/wrap-rotation-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/wrap-rotation

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c58bd1) 67.42% compared to head (45ad156) 67.42%.

❗ Current head 45ad156 differs from pull request most recent head 8396e84. Consider uploading reports for the commit 8396e84 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files         519      519           
  Lines       16063    16064    +1     
  Branches     2047     2048    +1     
=======================================
+ Hits        10830    10831    +1     
  Misses       4904     4904           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala enabled auto-merge (squash) February 6, 2024 17:15
Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8396e84
Status: ✅  Deploy successful!
Preview URL: https://aa92c52b.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-wrap-rotation.js-sdk-toolchain.pages.dev

View logs

@cazala cazala merged commit d1c5f40 into main Feb 6, 2024
8 checks passed
@cazala cazala deleted the feat/wrap-rotation branch February 6, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants